-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for when args.path is not used #90
Conversation
@uilianries Decided to make my first contribution :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michxymi Thank you for your first contribution! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! :)
We're delaying the merge until we do some behind the scenes work on the repo itself, will ping you when ready
Thanks both. I should have started from this but I also added some unit tests for all the possible args. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New tests!! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got lost in the sea of other work - thanks to @danimtb for the ping that this was still open :)
With the current implementation of the CCI
export_all_versions
command you can either pass a config file, a path or a name.There's currently a bug when not using a path argument. When either the config file or a name is parsed
args.path
is still used to locate the recipes directory. However because no path has been parsed as an arg it is undefined (i.e None).This PR adds a check condition to check if
args.path
is undefined and if it is, it uses thecwd/recipes
path, to comply with the expectation that this script should run from the root of a CCI file tree. When a path is indeed requested andargs.path
is not undefined, its value is used.