Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutotoolsToolchain: Honor tools.apple:enable_bitcode & tools.apple:enable_arc #15027

Open
wants to merge 4 commits into
base: release/2.0
Choose a base branch
from

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Oct 29, 2023

Changelog: (Feature): Honor tools.apple:enable_bitcode & tools.apple:enable_arc in AutotoolsToolchain.
Docs: https://github.com/conan-io/docs/pull/XXXX

closes #12197

Similar to #10985 but for AutotoolsToolchain., except that nothing is done for tools.apple:enable_visibility because I consider that this conf is useless and doesn't make sense.
In a sense tools.apple:enable_bitcode & tools.apple:enable_arc shouldn't have been added I think, but since they are here and implemented in CMakeToolchain, conan should be consistent in all toolchains (unless you want to deprecate these conf).

Also it's worth noting that #12197 (comment) is incorrect (or not correct anymore). openssl recipe uses AutootoolsToolchain in order to collect flags for configure step.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Apple flags are not sent to other build systems (bitcode, arc, visibility)
1 participant