Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC][feature] find_libraries function #15866

Closed

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Mar 13, 2024

Changelog: Feature: Created find_libraries function (alternative to collect_libs).
Docs: https://github.com/conan-io/docs/pull/XXXX

@franramirez688 franramirez688 modified the milestones: 2.2.0, 1.64 Mar 13, 2024
@franramirez688 franramirez688 changed the base branch from develop2 to develop March 13, 2024 15:48
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I now understand better the intent of this :)

My main comment is that I think we want to do this together with a re-design of the cpp_info capabilities (CPS-like) for defining libraries more explicitly, including types, import-libs and details like that

from urllib.parse import urlparse
from urllib.request import url2pathname

import six
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No six import should be necessary anymore! I thought we had gotten rid of this 😅

@franramirez688 franramirez688 modified the milestones: 1.64, 2.3.0 Mar 26, 2024
@franramirez688 franramirez688 changed the title [POC][feature] fetch_libraries function [POC][feature] find_libraries function Apr 26, 2024
@memsharded memsharded modified the milestones: 2.3.0, 2.4.0 Apr 29, 2024
@franramirez688 franramirez688 modified the milestones: 2.4.0, 2.5.0 May 31, 2024
@franramirez688 franramirez688 modified the milestones: 2.5.0, 2.6.0 Jun 21, 2024
@czoido czoido modified the milestones: 2.6.0, 2.7.0 Jul 31, 2024
@memsharded
Copy link
Member

memsharded commented Aug 25, 2024

To discuss with the progress in #16054

@memsharded memsharded removed this from the 2.7.0 milestone Aug 25, 2024
@franramirez688
Copy link
Contributor Author

Second round: #17105

@franramirez688 franramirez688 changed the base branch from develop to develop2 October 29, 2024 15:49
@memsharded
Copy link
Member

Closing this in favor of the new CppInfo based approach already merged in develop2

@memsharded memsharded closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants