Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom separators for append and prepend from profile #15957

Open
wants to merge 1 commit into
base: develop2
Choose a base branch
from

Conversation

SoShiny
Copy link

@SoShiny SoShiny commented Mar 26, 2024

fixes #15908

This is pertains to the [question] issue #15908 about mixed Windows and Unix paths in Msys2 when appending to INCLUDE or similar variables in the profile.
This proposed solution introduces the a notation like "+=(sep=;)" to gain fine grained control over the separator used for appending or prepending, and is intended to serve as a more concrete basis for discussion.

While adding the tests for this, I noticed that there might be an issue with TestProfileEnvRoundTrip::test_prepend. It reverses the order of definitions. Maybe someone can comment on this. It seems wrong, and was previously untested.

As this is for discussion, no documentation was added

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

@SoShiny SoShiny closed this Mar 26, 2024
@SoShiny SoShiny reopened this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Dealing with PATH-like env vars defined in profiles when using Windows subsystem (INCLUDE, msys2)
2 participants