Allow custom separators for append and prepend from profile #15957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15908
This is pertains to the [question] issue #15908 about mixed Windows and Unix paths in Msys2 when appending to INCLUDE or similar variables in the profile.
This proposed solution introduces the a notation like "+=(sep=;)" to gain fine grained control over the separator used for appending or prepending, and is intended to serve as a more concrete basis for discussion.
While adding the tests for this, I noticed that there might be an issue with
TestProfileEnvRoundTrip::test_prepend
. It reverses the order of definitions. Maybe someone can comment on this. It seems wrong, and was previously untested.As this is for discussion, no documentation was added
develop
branch, documenting this one.