Quote build_args in conan graph build-order #16594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
commented
Jul 3, 2024
memsharded
reviewed
Jul 3, 2024
AbrilRBS
commented
Jul 30, 2024
| tc.run("create dep") | ||
| tc.run("graph build-order . --order-by=configuration --build=dep/1.0 -f=json", redirect_stdout="order.json") | ||
| order = json.loads(tc.load("order.json")) | ||
| assert order["order"][0][0]["build_args"] == """--requires=dep/1.0 --build=dep/1.0 -o='dep/*:extras=cxx="yes" gnuext='"'"'no'"'"'' -o='dep/*:flags=define=FOO define=BAR define=BAZ'""" |
There was a problem hiding this comment.
It's a bit suprising for me that ='no' gets quoted to ='"'"'no'"'"''
memsharded
approved these changes
Oct 8, 2024
czoido
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Quote
build_argsinconan graph build-order -f=jsonto avoid issues with options with spaces.Changelog: Bugfix:
build_argsoptions ingraph build-ordernow respect the context of the reference.Docs: Omit
Closes #16593