Add properties to MakeDeps generator #16613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the receipt defines custom properties in the package_info() method
then these properties should appear as make variables, too. The pattern
of the make variable is
CONAN_PROPERTY_{dependency_name}_{property_name}
Furthermore handle case when _properties is None.
|
|
memsharded
reviewed
Jul 5, 2024
- _makefy_properties() always returns a dict - Simplification of define_multiple_variable_value jinja2 macro
memsharded
approved these changes
Jul 8, 2024
Co-authored-by: James <[email protected]>
It would break the makefile if we would create property values with newlines. Therefore we output a warning message and skip such properties.
|
Hi @memsharded,
However, the feautre is that the generator generates make variables for the properties of the direct dependencies and their components. |
|
You are right. The release notes are generated automatically from the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: MakeDeps generator generates make variables for dependencies and their components.
Docs: conan-io/docs#3794
Fixes #16572