Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with 'automatic' compatible packages and custom package ids #16772

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Commits on Aug 2, 2024

  1. Issue with 'automatic' compatible packages and custom package ids

    In case the recipe uses its own package_id() and compatible packages
    are generated automatically (e.g. Visual Studio vs msvc), then the compatible
    packages will use wrong 'base' info set for the compatible package id
    generation.
    
    In case the recipe's own package_id() erases a few options / settings,
    the compatible packages will not know about it, as those are generated prior
    the recipe's package_id() is being called.
    
    The change makes sure that first the recipe's package_id() is called, then
    the compatible packages are generated, so that they pick up the updated
    info set.
    harsszegi committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    791ddc4 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. test that crashes

    memsharded committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    157bfe0 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Making sure msvc_compatible handling partially set compiler settings

    In case a custom package_id() erased some of the compiler settings for
    'msvc', a 'Visual Studio' equivalent should be created that also
    doesn't have the (possibly) erased elements.
    harsszegi committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    581ad58 View commit details
    Browse the repository at this point in the history