python 3 compatability #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobane
commented
Feb 25, 2020
| @@ -36,10 +37,13 @@ def is_valid_request(self, request, parameters={}, | |||
| headers=headers, | |||
| parameters=parameters) | |||
|
|
|||
| if isinstance(oauth_request['oauth_signature'], six.string_types): | |||
| oauth_request['oauth_signature'] = oauth_request['oauth_signature'].encode('utf-8') | |||
There was a problem hiding this comment.
Everything in this PR was autogenerated except for this. This is needed to ensure the signature comparison happens correctly. Things worked previously because in python2:
>>> 'foo' == b'foo'
True
nobane
force-pushed
the
feature/python3
branch
from
f3586d9
to
438b6c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.