Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update comments and ReadMe; eliminate more semicolons for consistency #350

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

kswenson
Copy link
Member

This started with the simple task of updating the ReadMe with information about the new @concord-consortium/cloud-file-manager library option.

  • While at it I decided to add some information about the options that could be passed to the CFM in the ReadMe as well.
  • While doing that it seemed like some additional comments about the meaning of some of the options was warranted, although I bailed out before documenting all of them.
  • Finally, while looking at the definitions of the various options I was struck by the number of semicolons in this supposedly semicolon-less project and updated the ESLint configuration to make things more consistent.

@kswenson kswenson requested a review from dougmartin January 11, 2024 03:20
Copy link
Member

@dougmartin dougmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kswenson kswenson merged commit 2021f6d into master Jan 11, 2024
2 checks passed
@kswenson kswenson deleted the update-readme branch January 11, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants