Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openLocalFileWithConfirmation #361

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

scytacki
Copy link
Member

This checks if the document is dirty and asks for confirmation if it is. Then it opens the passed in file object.

Other changes:

  • example-app is updated to test this
  • s3-share-provider is removed all-providers.html to prevent warning about it not being valid
  • typo fixed in s3-provider comment
  • npm yalc commands updated to match other projects
  • readme updated with yalc instructions
  • new providers.md started to document the providers

This checks if the document is dirty and asks for confirmation if it is. Then it opens the passed in file object.

Other changes:
- example-app is updated to test this
- s3-share-provider is removed all-providers.html to prevent warning about it not being valid
- typo fixed in s3-provider comment
- npm yalc commands updated to match other projects
- readme updated with yalc instructions
- new providers.md started to document the providers
@scytacki scytacki marked this pull request as ready for review November 12, 2024 15:15
@scytacki scytacki requested a review from kswenson November 12, 2024 15:15
@scytacki
Copy link
Member Author

@kswenson one thing I don't have my head around is how the CFM works when CODAP is embedded in an iframe the way SageModeler uses it. I think in that case many of these client functions are "proxied" over postMessage to the parent frame. In that case this new function won't work. Probably it is fine to not deal with that now, but I wanted to point out that it isn't something I've figured out or tested.

Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kswenson
Copy link
Member

@kswenson one thing I don't have my head around is how the CFM works when CODAP is embedded in an iframe the way SageModeler uses it. I think in that case many of these client functions are "proxied" over postMessage to the parent frame. In that case this new function won't work. Probably it is fine to not deal with that now, but I wanted to point out that it isn't something I've figured out or tested.

It's not an area I'm very familiar with, either. @dougmartin may have a better idea.

@scytacki scytacki merged commit bb673a3 into master Nov 14, 2024
2 checks passed
@scytacki scytacki deleted the 188558077-open-local-confirmation branch November 14, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants