Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: describe graph by text (PT-188650872) #1692

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

emcelroy
Copy link
Contributor

@emcelroy emcelroy commented Dec 18, 2024

PT Stories: #188650872, #188700179

Copy link

cypress bot commented Dec 18, 2024

codap-v3    Run #5698

Run Properties:  status check passed Passed #5698  •  git commit b5c9c66b62: chore: use CFM for image export/download
Project codap-v3
Branch Review 188650872-describe-graph-by-text
Run status status check passed Passed #5698
Run duration 01m 53s
Commit git commit b5c9c66b62: chore: use CFM for image export/download
Committer Ethan McElroy
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 41.84100% with 139 lines in your changes missing coverage. Please review.

Project coverage is 68.17%. Comparing base (6287ab9) to head (b5c9c66).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
v3/src/components/graph/utilities/image-utils.ts 32.11% 89 Missing and 4 partials ⚠️
.../data-interactive/handlers/data-display-handler.ts 40.00% 14 Missing and 1 partial ⚠️
...s/data-display/models/data-display-render-state.ts 35.00% 12 Missing and 1 partial ⚠️
...c/components/graph/components/camera-menu-list.tsx 50.00% 7 Missing ⚠️
...src/components/graph/graph-data-display-handler.ts 22.22% 7 Missing ⚠️
v3/src/data-interactive/resource-parser.ts 33.33% 2 Missing ⚠️
...ts/data-display/components/legend/color-legend.tsx 0.00% 1 Missing ⚠️
.../data-display/components/legend/numeric-legend.tsx 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6287ab9) and HEAD (b5c9c66). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (6287ab9) HEAD (b5c9c66)
cypress 10 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1692       +/-   ##
===========================================
- Coverage   85.71%   68.17%   -17.54%     
===========================================
  Files         608      613        +5     
  Lines       31328    31560      +232     
  Branches     8099     8695      +596     
===========================================
- Hits        26853    21517     -5336     
- Misses       4320     9425     +5105     
- Partials      155      618      +463     
Flag Coverage Δ
cypress 43.03% <17.43%> (-31.29%) ⬇️
jest 53.81% <31.38%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 CODAP v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant