Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assign unique names to new data sets #1706

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Dec 24, 2024

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.87%. Comparing base (02af839) to head (256ed60).
Report is 29 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1706       +/-   ##
===========================================
+ Coverage   68.58%   85.87%   +17.28%     
===========================================
  Files         608      608               
  Lines       31242    31246        +4     
  Branches     8083     8624      +541     
===========================================
+ Hits        21426    26831     +5405     
+ Misses       9661     4093     -5568     
- Partials      155      322      +167     
Flag Coverage Δ
cypress 74.57% <100.00%> (+31.01%) ⬆️
jest 54.04% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Dec 24, 2024

codap-v3    Run #5691

Run Properties:  status check passed Passed #5691  •  git commit 6287ab9981: fix: assign unique names to new data sets (#1706)
Project codap-v3
Branch Review main
Run status status check passed Passed #5691
Run duration 05m 58s
Commit git commit 6287ab9981: fix: assign unique names to new data sets (#1706)
Committer Kirk Swenson
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 220
View all changes introduced in this branch ↗︎

@kswenson kswenson force-pushed the 186293627-unique-dataset-names branch from d916c52 to 256ed60 Compare December 24, 2024 20:59
@kswenson kswenson marked this pull request as ready for review December 24, 2024 21:13
@kswenson kswenson requested a review from eireland December 24, 2024 21:13
Copy link
Contributor

@eireland eireland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kswenson kswenson merged commit 6287ab9 into main Jan 3, 2025
24 checks passed
@kswenson kswenson deleted the 186293627-unique-dataset-names branch January 3, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants