Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update to use 's3-deploy-action' & 'ubuntu-latest' (PT-184551773) #709

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

433eros
Copy link

@433eros 433eros commented Mar 23, 2023

Addresses PT-184551773

@433eros 433eros force-pushed the ubuntu-18.04-brownout branch 2 times, most recently from 9575d22 to 3fa6860 Compare March 23, 2023 15:41
Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v2 build of CODAP is not like other CC projects. It has a very specialized build procedure that requires ruby and multiple steps. The ci build of v2 hasn't been working for some time, so I would love it for that problem to be addressed, but it will require a deep engagement with and understanding of the v2 build process. The straightforward approach used with most CC projects will not be sufficient in this case.

@433eros 433eros force-pushed the ubuntu-18.04-brownout branch from 3fa6860 to 4b1229b Compare March 29, 2023 18:32
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3ae5830) 81.32% compared to head (4b1229b) 81.32%.

❗ Current head 4b1229b differs from pull request most recent head b229c2c. Consider uploading reports for the commit b229c2c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #709   +/-   ##
=======================================
  Coverage   81.32%   81.32%           
=======================================
  Files         204      204           
  Lines        8140     8140           
  Branches     2160     2160           
=======================================
  Hits         6620     6620           
  Misses       1445     1445           
  Partials       75       75           
Flag Coverage Δ
cypress 60.76% <ø> (ø)
jest 56.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@433eros 433eros force-pushed the ubuntu-18.04-brownout branch from 8552021 to b229c2c Compare March 29, 2023 18:46
@kswenson kswenson added the v2 CODAP v2 label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 CODAP v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants