chore: remove unnecessary aria labels (PT-188528220) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcelroy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#188528220
As noted in the PT story comments, the use of
arial-labelwith value "speaker" on theh3elements was causing screen readers to say "heading level 3 - speaker" instead of "heading level 3 - DAVAI" or "heading level 3 - User" which is more appropriate for identifying the speaker. The latter is what screen readers say when thearia-labelattribute is removed. Even though thearia-labelon associatedpelements wasn't causing a similar problem with the message content, I removed that, too, since it doesn't seem like it's appropriate use of thearia-labelattribute. Plus, thepelement doesn't supportaria-label.