Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: v3.24.0 #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bump: v3.24.0 #39

wants to merge 2 commits into from

Conversation

diogo-sr
Copy link

@diogo-sr diogo-sr commented Sep 5, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package aim using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@diogo-sr
Copy link
Author

diogo-sr commented Sep 5, 2024

@conda-forge-admin, please rerender

@synapticarbors
Copy link
Member

Please add setuptools to the host section.

@synapticarbors
Copy link
Member

Additionally, please look at the requirements upstream. I believe there is going to be some issues with packages not currently being available on conda-forge.

@synapticarbors
Copy link
Member

Specifically aimrocks doesn't have a source distribution (https://pypi.org/project/aimrocks/#files). See:
aimhubio/aimrocks#34

@diogo-sr
Copy link
Author

diogo-sr commented Sep 5, 2024

Additionally, please look at the requirements upstream. I believe there is going to be some issues with packages not currently being available on conda-forge.

Thanks for the heads-up. I'll first try to get the build working locally

@diogo-sr
Copy link
Author

diogo-sr commented Sep 5, 2024

Specifically aimrocks doesn't have a source distribution (https://pypi.org/project/aimrocks/#files). See: aimhubio/aimrocks#34

Oh yes, you had already mentioned that on the other MR that is open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants