Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower pin for rhash with compatible soname #193

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zklaus
Copy link

@zklaus zklaus commented Aug 31, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes part of #192, the other part being a repodata patch.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zklaus
Copy link
Author

zklaus commented Aug 31, 2023

@conda-forge-admin, please rerender

@zklaus zklaus changed the title Rhash soname Lower pin for rhash with compatible soname Aug 31, 2023
@zklaus zklaus mentioned this pull request Aug 31, 2023
@jschueller
Copy link
Contributor

I manually pinned conda-build in the scripts because of a bug, and rerendering cancels that

@zklaus
Copy link
Author

zklaus commented Aug 31, 2023

I manually pinned conda-build in the scripts because of a bug, and rerendering cancels that

Thanks, that makes sense. Let's see how this goes...

@isuruf
Copy link
Member

isuruf commented Aug 31, 2023

Why is this needed?

@zklaus
Copy link
Author

zklaus commented Aug 31, 2023

Because new Cmake builds are incompatible with rhash<1.4.4. This showed up in several CIs (see list below) as

cmake: error while loading shared libraries: librhash.so.0: cannot open shared object file: No such file or directory

In other words, it's not really that Cmake depends on rhash>=1.4.4, but rather that a Cmake build that was produced with any Rhash version prior to 1.4.4 should have a run requirement of rhash<1.4.4 and any build produced with Rhash 1.4.4 or newer should have a run requirement of rhash>=1.4.4. Perhaps some Jinja magic would be a better way to achieve this?

Here the promised list of failed CIs:

The same issue was reported on a few other feedstocks, but because the builds were restarted, it's a bit hard to dig up the logs.

@zklaus
Copy link
Author

zklaus commented Sep 14, 2023

@isuruf, I understand the fixed repodata patch solves the issue, but is it still best practice to include the pin? Otherwise we can just close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants