Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinguish github_actions_labels for CPU vs. CUDA builds #6910

Merged
merged 2 commits into from
Jan 26, 2025
Merged

distinguish github_actions_labels for CPU vs. CUDA builds #6910

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ca75bc
distinguish github_actions_labels for CPU vs. CUDA builds
h-vetinari Jan 10, 2025
e41e1b6
provide a clearer indication for intended use of github_actions_label…
h-vetinari Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions recipe/conda_build_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,13 +172,20 @@ docker_image: # [os.environ.get("BUILD_PLA
- quay.io/condaforge/linux-anvil-aarch64:alma9 # [os.environ.get("CF_CUDA_ENABLED", "False") == "True" and os.environ.get("BUILD_PLATFORM") == "linux-aarch64" and os.environ.get("DEFAULT_LINUX_VERSION", "alma9") == "alma9"]
- quay.io/condaforge/linux-anvil-ppc64le:alma9 # [os.environ.get("CF_CUDA_ENABLED", "False") == "True" and os.environ.get("BUILD_PLATFORM") == "linux-ppc64le" and os.environ.get("DEFAULT_LINUX_VERSION", "alma9") == "alma9"]

# to be overridden per feedstock; part of zip so that CPU builds can choose different agents than GPU builds
github_actions_labels: # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- dummy # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- dummy # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- dummy # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]

h-vetinari marked this conversation as resolved.
Show resolved Hide resolved
zip_keys:
- # [unix]
- c_compiler_version # [unix]
- cxx_compiler_version # [unix]
- fortran_compiler_version # [unix]
- cuda_compiler # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- cuda_compiler_version # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- github_actions_labels # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these zip keys have become almost impossible to read.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what alternative you'd have in mind - unless we completely redesign how conda works (or stop supporting CUDA builds), this is irreducible complexity IMO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can start with: #6917

- docker_image # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True" and os.environ.get("BUILD_PLATFORM", "").startswith("linux-")]
- # [win64 and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- cuda_compiler # [win64 and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
Expand Down
Loading