Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering README #1785

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Fix rendering README #1785

merged 6 commits into from
Oct 25, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 23, 2023

Fixes some bugs from #1752

@isuruf isuruf requested a review from a team as a code owner October 23, 2023 14:45
Copy link
Member

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add the PR number to the original news item at https://github.com/isuruf/conda-smithy/blob/9b02aa7b17fd2bb40177c9cbd728f46f45ec5b2d/news/1752-readme-channels.rst?plain=1#L7.

Should look like this:

- * Use the channels defined in `conda_build_config.yaml` (instead of those in `conda-forge.yml`) to render `README.md`. (#897 via #752)
+ * Use the channels defined in `conda_build_config.yaml` (instead of those in `conda-forge.yml`) to render `README.md`. (#897 via #1752, #1785)

🙏

@jaimergp jaimergp merged commit 523324f into conda-forge:main Oct 25, 2023
@jdblischak
Copy link
Member

Is there a plan for updating the documentation after this update is released? I didn't see any related Issue or PR on conda-forge.github.io. I can assist with this if needed

https://conda-forge.org/docs/maintainer/conda_forge_yml.html#channels
https://github.com/conda-forge/conda-forge.github.io/blob/0ba1bc21e42752f368b50c8169f96424322a9711/src/maintainer/conda_forge_yml.rst#channels

@isuruf
Copy link
Member Author

isuruf commented Oct 30, 2023

Yes we should open a new PR. A PR or a issue is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants