Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mambaforge and macos SDK files to feedstock gitignore file #1810

Closed
wants to merge 4 commits into from
Closed

Add Mambaforge and macos SDK files to feedstock gitignore file #1810

wants to merge 4 commits into from

Conversation

hadim
Copy link
Member

@hadim hadim commented Nov 28, 2023 •
edited
Loading

Checklist

  • Added a news entry

I found those two files to be annoying when debugging a feedstock locally on macOS.

@hadim hadim requested a review from a team as a code owner November 28, 2023 00:17
@hmaarrfk
Copy link
Contributor

I feel like #1413 will get merged in first :/

@hadim
Copy link
Member Author

hadim commented Nov 28, 2023

I'll wait for a maintainer approval before fixing the test and adding the entry in the news file.

@hadim
Copy link
Member Author

hadim commented Nov 28, 2023

I feel like #1413 will get merged in first :/

oh ok - I wasn't aware of that PR. Well, let me know if I should close here or not. I would argue that if you think #1413 will take time before being merged, maybe that one could be a quick fix waiting for it.

@hmaarrfk
Copy link
Contributor

you can leave it open. I think it is a good idea and we should merge this if that other PR takes too long.

Its a rather "complicated" .gitignore file which is why it has taken so long to get approved.

hmaarrfk
hmaarrfk approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@hmaarrfk hmaarrfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to merge this if #1413 dargs on to Dec 15.

@jaimergp
Copy link
Member

jaimergp commented Dec 4, 2023

#1413 went in and covers these changes too, right? If you agree, we can close here.

@hadim hadim closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmaarrfk hmaarrfk hmaarrfk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hadim @hmaarrfk @jaimergp