Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: need to escape $ in regex for noarch python hint #2184

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

beckermr
Copy link
Member

@beckermr beckermr commented Dec 12, 2024

Checklist

  • Added a news entry
  • Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

closes #2183

@beckermr beckermr requested a review from a team as a code owner December 12, 2024 12:11
@beckermr
Copy link
Member Author

@conda-forge/core this one is ready for review!

@wolfv
Copy link
Member

wolfv commented Dec 12, 2024

Could also make sense to replace all with {{ -> \${{?

@beckermr
Copy link
Member Author

not sure.

@beckermr beckermr merged commit 217b0b5 into main Dec 12, 2024
2 checks passed
@beckermr beckermr deleted the fix-v1-noarchpy-again branch December 12, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linting for v1 recipes fail cuz of false positive (CFEP 25)
2 participants