Support skipping python_min and pip_no_build_backend hints
#2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support `hint_python_min` in `linter.skip`. I went for a single token for all `python_min` hints, since it seems reasonable to assume that if one explicitly disables this, the feedstock was already inspected for appropriate `python_min` usage. Fixes conda-forge#2170
Support skipping the hints about missing build backend dependency, e.g. when the package itself is providing the build backend (e.g. in poetry-core-feedstock). Also requested in issue conda-forge#2170.
Fix the error such as:
```
Traceback (most recent call last):
File "/home/mgorny/miniforge3/bin/conda-smithy", line 10, in <module>
sys.exit(main())
^^^^^^
File "/home/mgorny/git/conda-smithy/conda_smithy/cli.py", line 767, in main
args.subcommand_func(args)
File "/home/mgorny/git/conda-smithy/conda_smithy/cli.py", line 645, in __call__
lints, hints = linter.main(
^^^^^^^^^^^^
File "/home/mgorny/git/conda-smithy/conda_smithy/lint_recipe.py", line 733, in main
results, hints = lintify_meta_yaml(
^^^^^^^^^^^^^^^^^^
File "/home/mgorny/git/conda-smithy/conda_smithy/lint_recipe.py", line 281, in lintify_meta_yaml
if "lint_noarch_selectors" not in lints_to_skip:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable
```
when `conda-forge.yml` contains an empty key, e.g.:
```
linter:
skip:
```
Noticed this accidentally while testing the other changes.
h-vetinari
reviewed
Jan 6, 2025
tests/test_lint_recipe.py
Outdated
Comment on lines
3344
to
3345
| if not expected_hints: | ||
| pytest.skip("No hints expected") |
There was a problem hiding this comment.
Why should we need to skip this test if there are no expected hints? We could reformulate the test below to expect empty hints, no?
There was a problem hiding this comment.
It always expected empty hints. I've skipped it because it's redundant, i.e. doesn't test anything.
There was a problem hiding this comment.
I'm not sure I agree. It's still testing that the config in conda-forge.yml doesn't break the case of "no hints expected".
There was a problem hiding this comment.
That makes sense, I'll update it. In the end, the skips don't save that much time, and could be confusing.
h-vetinari
approved these changes
Jan 6, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)Fixes #2170
Add options to skip linter checks for
python_minand missing build backend, both requested in #2170. While at it, fix aTypeErrorthat occurs whenconda-forge.ymlcontains emptylinter:orskip:keys.