Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify fix_build.patch #49

Merged
merged 4 commits into from
Jan 26, 2021
Merged

Simplify fix_build.patch #49

merged 4 commits into from
Jan 26, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 23, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

As discussed in #39, thanks to #38 it should be now possible to drastically simplify the fix_build.patch .

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor

Seems like the cinttypes patch is still required. Probably something we should patch upstream.

@Tobias-Fischer
Copy link
Contributor

Looking good now, thanks a lot. Could you please bump the build number and re-render just for good measure?

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

Looking good now, thanks a lot. Could you please bump the build number and re-render just for good measure?

Done!

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like I wasn't able to push to the patch-4
branch of traversaro/gazebo-feedstock. Did you check the "Allow edits from maintainers" box?

NOTE: PRs from organization accounts cannot be rerendered because of GitHub
permissions.

@Tobias-Fischer
Copy link
Contributor

I guess it's fine to re-render next time. Thanks for the PR!

@Tobias-Fischer Tobias-Fischer merged commit 37dacd7 into conda-forge:master Jan 26, 2021
@traversaro traversaro deleted the patch-4 branch January 26, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants