Add sync experiment dependencies #36
Conversation
hyperrealist
requested review from
gwbischof,
jklynch,
kbeeperez and
mrakitin
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@mrakitin the CI failures seem to be related to curio. I ran into this before and wrote an issue. As far as I know they have fixed it in the git repo, but they are not publishing to pypi anymore.
|
|
If it's only the Windows builds failing, we can just exclude them. We don't use this package for non-Linux installations. |
There was a problem hiding this comment.
Left my review comments. Thanks for the contribution, @hyperrealist!
| - nslsii | ||
| - nslsii._version | ||
| - nslsii.ad33 | ||
| - nslsii.common | ||
| - nslsii.common.ipynb | ||
| - nslsii.common.ipynb.animation | ||
| - nslsii.common.ipynb.info | ||
| - nslsii.common.ipynb.logutils | ||
| - nslsii.common.ipynb.nbviewer | ||
| - nslsii.detectors | ||
| - nslsii.detectors.trigger_mixins | ||
| - nslsii.detectors.utils | ||
| - nslsii.detectors.xspress3 | ||
| - nslsii.detectors.zebra | ||
| - nslsii.devices | ||
| # The following error happened for Win/Py312: | ||
| # AttributeError: module 'multiprocessing.connection' has no attribute 'CHALLENGE'. Did you mean: '_CHALLENGE'? | ||
| # Excluding the test for that platform/Python version for now. | ||
| - nslsii.iocs.eps_two_state_ioc_sim # [not (win and py==312)] | ||
| # Uncomment the next line once https://github.com/NSLS-II/nslsii/issues/129 | ||
| # is resolved. | ||
| # - nslsii.iocs.thermo_sim | ||
| - nslsii.temperature_controllers | ||
| - nslsii.transforms |
There was a problem hiding this comment.
Some imports are still useful to capture potentially missing dependencies as __init__ on the nslsii level may not have everything exposed. Can we revert those? I have a command which can generate the list: https://gist.github.com/mrakitin/b53d00d7ea167f3c7515f2929dd1199c.
| entry_points: | ||
| - sync-experiment = nslsii.sync_experiment:main | ||
| - what-is-ioc = nslsii.epics_utils:main | ||
| noarch: python |
There was a problem hiding this comment.
If we decide to skip Windows builds, this line needs to be replaced with skip: true # [win] and then the feedstock should be rerendered.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)This PR updates
meta.yamlusing suggestions fromgrayskull pypi nslsii. Also the build number is incremented, and the list of recipe maintainers updated.