Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lets see if we can run all the tests on osx, linux, win #77

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mikemhenry
Copy link
Contributor

Just using this to test if OSX is running unit tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@peastman
Copy link
Contributor

Looks good. I don't think the conda-forge maintainers want us running the full test suite on every build, since that would consume a lot of CI resources. But it's useful to test this and see what happens.

@mikemhenry
Copy link
Contributor Author

I'll double check the logs from this PR and the last one I merged in to see if the testing output on osx is different in them to make sure this is doing something.

I don't want to waste CI resources but I also don't want to ship broken packages to our users and since we have a documented case where that happened, we should be okay.

@isuruf
Copy link
Member

isuruf commented May 18, 2022

Wasting CI resources is not the issue. We have 200 parallel jobs for 10k+ feedstocks and this is taking 53 jobs (which is better now because of the removal of older cuda versions). If the jobs are quick, that shouldn't affect much, but the more time it takes, the more chance of this feedstock being a bottleneck for other maintainers.
Please don't open more than one PR simultaneously.

@@ -95,6 +94,8 @@ test:
commands:
- env with_test_suite={{ with_test_suite }} bash test_openmm.sh # [unix]
- set with_test_suite={{ with_test_suite }} && .\test_openmm.bat # [win]
- env with_test_suite={{ with_test_suite }} bash test_openmm.sh # [osx]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line might be redundant... The unix selector two lines above is an alias for linux or osx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants