Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python311 #19

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python311.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3353156433, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@inducer
Copy link
Contributor

inducer commented Oct 30, 2022

inducer/pycuda#359

@jakirkham
Copy link
Member

Interesting. We just rebuilt boost with that fix recently ( conda-forge/boost-feedstock#156 ). Maybe CI is out-of-date? Let's try restarting 🍀

@jakirkham
Copy link
Member

@conda-forge-admin, please restart CI

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pycuda-feedstock/actions/runs/3364474214.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@jakirkham
Copy link
Member

jakirkham commented Oct 31, 2022

That doesn't seem to help.

The particular error shown in CI currently is fixed in PR ( boostorg/python#328 ), which has been included in Boost since 1.76.0. In CI we are building with Boost 1.78.0 (so should already have that fix).

However, on closer inspection, it seems these headers are coming from pycuda itself? In particular it looks like there is some kind of Boost.Python vendoring. This vendored copy of Boost.Python would need to be updated.

Edit: Likely am missing context. Following up here ( inducer/pycuda#359 (comment) ).

@jakirkham
Copy link
Member

Ah thank you Isuru! 🙏 Figured there was something I wasn't understanding 😅

@jakirkham
Copy link
Member

Think the naming structure expected by pycuda differs from that used in the boost package. For example pycuda is looking for libboost_python-py38.so; whereas, in boost this is called libboost_python38.so. Not sure if there is a way to specify this naming convention to pycuda. If not, suppose we could always resort to adding symlinks and removing them.

@jakirkham
Copy link
Member

jakirkham commented Oct 31, 2022

Thanks Isuru! 🙏 Looks like that found the library 🎉

Appears that pycuda will need a similar patch to this Boost.Python one ( boostorg/python#328 ). Namely to make use of Py_SET_TYPE for Python 3.9+.

@inducer
Copy link
Contributor

inducer commented Nov 22, 2022

Superseded by #20.

@inducer inducer closed this Nov 22, 2022
@jakirkham jakirkham reopened this Nov 22, 2022
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@jakirkham
Copy link
Member

We still need this for the migrator, which appears to be missing from main. That said, we need the bot to regenerate the PR

@jakirkham jakirkham added the bot-rerun Instruct the bot to retry the PR label Nov 22, 2022
@jakirkham
Copy link
Member

Hmm...unfortunately the bot thinks this is done even though it is not. Let's try refreshing...

@conda-forge-admin, please re-render

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@jakirkham jakirkham removed the bot-rerun Instruct the bot to retry the PR label Nov 22, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pycuda-feedstock/actions/runs/3520202249.

@jakirkham
Copy link
Member

Ok have tidied this up. Should be ready for review 🙂

@inducer inducer merged commit 653398e into conda-forge:main Nov 22, 2022
@inducer
Copy link
Contributor

inducer commented Nov 22, 2022

LGTM, thanks! And sorry I closed this prematurely.

@jakirkham
Copy link
Member

All good. Thanks for all the fixes and review! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants