-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune torch cuda arch list to match upstream #306
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12499338117. Examine the logs at this URL for more detail. |
It seems like a mistake to remove 8.9 to me. This targets 4090s and 6000 ada |
Is there a difference between the code generated for 8.6 vs code generated for 8.9? Removing 8.9 here does not mean that those targets are dropped. Just that 8.9 compute capability devices will use code compiled for 8.6. |
I’m honestly really not sure and it is difficult to tell without further inspection. How can one tell in practice? |
You have to run benchmarks to see if it does make sense. Since this is what upstream wheels do and most people use those wheels, I think we would have seen reports upstream if there was a difference. |
I think very few people have skills to compile pytorch from source. I can run a benchmark in 1 week if you can prepare one for me. I have a 4090. |
I think there are a few differences in the capabilities of 8.6 and 8.9 that we should keep both... they seem hard to trigger and would take us a lot of time to design benchmarks for (i think) |
It also seems that many lesser 40 series would benefit. Not just “those with highest budgets” |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmarks are always great to inform decisions on what to build yes or no, so 👍🏼 from me for waiting for those. In principle this change seems correct though, and in the absence of evidence to the contrary of significant value of making different choices, it seems like the upstream TORCH_CUDA_ARCH_LIST
should always be matched.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)