-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for CUDA 12 w/arch support #55
Rebuild for CUDA 12 w/arch support #55
Conversation
The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems [see this issue]( conda-forge/conda-forge.github.io#1963 ). Please feel free to raise any issues encountered there. Thank you! 🙏
…nda-forge-pinning 2023.11.02.10.11.59
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi @jakirkham, do you happen to have any idea what's going on here? The compile seems to fail with a pybind11 related issue, but it also says that nvcc failed.
|
Hi Tobias, yes this does ring a bell There was an issue with pybind11 and early CUDA 12 versions ( pybind/pybind11#4606 ). There was a fix on the pybind11 side ( pybind/pybind11#4893 ), which is currently unreleased. Also CUDA 12.2+ has a fix. So eventually this will go away. For now we will need a workaround Side note: It's unfortunate that PyTorch is vendoring pybind11. That makes things harder to understand/fix In terms of making progress in the near term, would try downgrading to GCC 11 (from 12) in the CUDA 12 migrator. An example of this is in commit ( conda-forge/pp-sketchlib-feedstock@68d36e6 ). There is more discussion in the associated PR that added that change Would give that a try and let us know how it goes |
The combination of pybind11 + GCC 12 + nvcc 12 runs into compilation errors. This is documented in a pybind11 issue. To workaround this, configure the CUDA 12 migrator to use GCC 11, which shouldn't have this issue. xref: pybind/pybind11#4606 xref: conda-forge/pp-sketchlib-feedstock@68d36e6
@conda-forge-admin please rerender |
…nda-forge-pinning 2023.11.07.18.09.01
Awesome, that did the trick @jakirkham, many thanks for that :) |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
This PR has been triggered in an effort to update cuda120.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
Here are some more details about this specific migrator:
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6756035633, please use this URL for debugging.