Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable buildtin_vdt fixing #261 #262

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Enable buildtin_vdt fixing #261 #262

merged 1 commit into from
Sep 18, 2024

Conversation

DraTeots
Copy link
Contributor

@DraTeots DraTeots commented Jul 24, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged) - NO as from {% set build_number = os.environ["ROOT_CONDA_BUILD_NUMBER"] %} I thought it is done automatically
  • Reset the build number to 0 (if the version changed) - NO (see above)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering) - NO from the documentation it seems not needed
  • Ensured the license file is being packaged. - NO license file packaging is not affected

closing #261

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@DraTeots
Copy link
Contributor Author

It looks like OSX is failing independently of this PR.

@henryiii henryiii merged commit 6e8f11d into conda-forge:main Sep 18, 2024
16 of 27 checks passed
@henryiii
Copy link
Contributor

Ah, missed the build number, added the bump manually. The build number from envvar is only for ROOT test builts, the feedstock otherwise sets is normally. Notice the if statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants