lint

conda-incubator · Mar 5, 2024 · 4517804 · 4517804
1 parent c8f99b9
commit 4517804
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 6 deletions.
diff --git a/src/features/metadata/components/EnvBuilds.tsx b/src/features/metadata/components/EnvBuilds.tsx
@@ -91,7 +91,7 @@ export const EnvBuilds = ({
                 />
               )) ||
                 // If the selected build is a failed build, render the link to the build log.
-                (showLogLink && [". ", logLink])}
+                (showLogLink && <>. {logLink}</>)}
             </Typography>
           </StyledMetadataItem>
         </>

diff --git a/test/metadata/EnvBuilds.test.tsx b/test/metadata/EnvBuilds.test.tsx
@@ -9,7 +9,12 @@ describe("<EnvBuilds />", () => {
   it("should render component", () => {
     const component = render(
       <Provider store={store}>
-        <EnvBuilds selectedBuildId={1} builds={[BUILD]} />
+        <EnvBuilds
+          currentBuildId={1}
+          selectedBuildId={1}
+          builds={[BUILD]}
+          mode="read-only"
+        />
       </Provider>
     );
     expect(component.container).toHaveTextContent("Builds");
@@ -18,7 +23,12 @@ describe("<EnvBuilds />", () => {
   it("should show a progress bar if builds are not available", () => {
     const component = render(
       <Provider store={store}>
-        <EnvBuilds selectedBuildId={1} builds={[]} />
+        <EnvBuilds
+          currentBuildId={1}
+          selectedBuildId={1}
+          builds={[]}
+          mode="read-only"
+        />
       </Provider>
     );
     const progressBar = component.getByRole("progressbar");
@@ -29,7 +39,12 @@ describe("<EnvBuilds />", () => {
     const failedBuild = { ...BUILD, status: "FAILED" };
     const { getByTestId, getByRole } = render(
       <Provider store={store}>
-        <EnvBuilds selectedBuildId={1} builds={[failedBuild]} />
+        <EnvBuilds
+          currentBuildId={1}
+          selectedBuildId={1}
+          builds={[failedBuild]}
+          mode="read-only"
+        />
       </Provider>
     );
     expect(getByRole("link", { name: "Log" })).toBeInTheDocument();
@@ -41,7 +56,12 @@ describe("<EnvBuilds />", () => {
   it("should not render log link for normal build", () => {
     const { getByTestId, queryByRole } = render(
       <Provider store={store}>
-        <EnvBuilds selectedBuildId={1} builds={[BUILD]} />
+        <EnvBuilds
+          currentBuildId={1}
+          selectedBuildId={1}
+          builds={[BUILD]}
+          mode="read-only"
+        />
       </Provider>
     );
     expect(queryByRole("link", { name: "Log" })).not.toBeInTheDocument();

diff --git a/test/testutils.tsx b/test/testutils.tsx
@@ -86,7 +86,8 @@ export const BUILD = {
   scheduled_on: "2022-11-08T14:28:05.655564",
   started_on: "2022-11-08T14:28:05.655564",
   ended_on: "2022-11-08T14:28:05.655564",
-  build_artifacts: []
+  build_artifacts: [],
+  status_info: null
 };
 
 export const mockTheme = (children: any) => {