Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change artifact link names #273

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Change artifact link names #273

merged 3 commits into from
Aug 24, 2023

Conversation

steff456
Copy link
Contributor

Fixes #195.

Description

This pull request:

  • Changes the artifact link names to the specified names in the issue
  • Adjust the tests to the changes

Before
image

After
image

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentaion (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

  • The prefix Show will open in a new tab the requested artifact
  • The prefix Download will ask the user the desired path to download the requested artifact

A follow up PR will be made once the design system for links is determined.

@steff456 steff456 added type: bug 🐛 Something isn't working area: user experience 👩🏻‍💻 Items impacting the end-user experience labels Aug 17, 2023
@steff456 steff456 added this to the 🚀 JATIC - Q1 milestone Aug 17, 2023
@steff456 steff456 self-assigned this Aug 17, 2023
trallard
trallard reviewed Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456 - I left a question regarding the Download archive but overall looks good to me.

src/features/artifacts/stories/ArtifactsList.stories.tsx Outdated Show resolved Hide resolved
@steff456
Copy link
Contributor Author

The last commit reorganizes the artifacts and groups the options that start with "Show" , so now it looks like this,

image

trallard
trallard reviewed Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456 - I have questions about the tests, but can target separately

trallard
trallard approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @steff456 - I have questions about the tests, but can target separately

@trallard trallard merged commit 57f9d71 into conda-incubator:main Aug 24, 2023
1 check passed
@steff456 steff456 deleted the fix-195 branch August 24, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trallard trallard trallard approved these changes

Assignees

@steff456 steff456

Labels
area: user experience 👩🏻‍💻 Items impacting the end-user experience needs: review 👀 type: bug 🐛 Something isn't working
Projects
conda-store 🐍
Status: Done 💪🏾
Milestone
🚀 JATIC - Q1
Development

Successfully merging this pull request may close these issues.

Artifact link names are inconsistent
2 participants
@steff456 @trallard