Skip to content

Commit

Permalink
Merge pull request #2528 from jakirkham/backport_pr_2259
Browse files Browse the repository at this point in the history
Backport "only set env vars in build scripts that actually have values"
  • Loading branch information
msarahan authored Nov 28, 2017
2 parents 5ebf736 + ab2d893 commit 3c9ad90
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion conda_build/windows.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,8 @@ def build(m, bld_bat, config):
# more debuggable with echo on
fo.write('@echo on\n')
for key, value in env.items():
fo.write('set "{key}={value}"\n'.format(key=key, value=value))
if value:
fo.write('set "{key}={value}"\n'.format(key=key, value=value))
fo.write(msvc_env_cmd(bits=bits, config=config,
override=m.get_value('build/msvc_compiler', None)))
# Reset echo on, because MSVC scripts might have turned it off
Expand Down

0 comments on commit 3c9ad90

Please sign in to comment.