Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update
conda inspect channels
#5033Update
conda inspect channels
#5033Changes from 7 commits
bf82c42
6b0efa7
db9691f
44f6c96
1a1ca4e
9c1100f
e5ba600
2e57946
fd96c8b
44222cf
432d5a4
423bc5f
c4745bb
bb4e818
e956c99
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this use
KNOWN_SUBDIRS
inconda.somewhere.constants
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered this, but opted to leave that as a separate exercise since the primary goal was to stop using legacy solve stuff, not to fix
conda inspect channels
. Ideally this should be a customizable field from the CLI.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did
additional_packages
go? Can you explain why is it being removed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understood (and from my testing) this doesn't make a difference. The package already defines its Python dependency so theres no need for us to also define it here.
This was actually prompted by the removal of the regex search on 183. Packages that do not follow the
pyNN
build string pattern fails (e.g. https://anaconda.org/conda-test/itsdangerous/files).See
conda inpsect channels conda-test --test-installable
.