Use conda_build.metadata.MetaData's get_section & get_value
#5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
kenodegard
changed the title
get_section & get_valueconda_build.metadata.MetaData's get_section & get_value
3 tasks
dholth
reviewed
Nov 3, 2023
| @@ -545,12 +543,11 @@ def meta_vars(meta, skip_build_id=False): | |||
| ): | |||
| d.update(get_hg_build_info(hg_dir)) | |||
|
|
|||
| # use `get_value` to prevent early exit while name is still unresolved during rendering | |||
| d["PKG_NAME"] = meta.get_value("package/name") | |||
| d["PKG_NAME"] = meta.name() | |||
There was a problem hiding this comment.
it's almost surprising these are not properties meta.name
There was a problem hiding this comment.
yup, especially surprising when other values of MetaData are properties 🤷🏻♂️
beeankha
approved these changes
Nov 3, 2023
jezdez
approved these changes
Nov 3, 2023
This was referenced Dec 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The MetaData object contains lots of fancy helper methods/properties (e.g.
get_valueandbuild_id). Let's attempt to more consistently use these features instead of reaching into the MetaData's internals.Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?