Require explicit answer in SH license prompt (#722)

* Require explicit answer in SH license prompt * add news
conda · Sep 30, 2023 · 2302872 · 2302872
1 parent 18e97b2
commit 2302872
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/constructor/header.sh b/constructor/header.sh
@@ -268,10 +268,10 @@ __LICENSE__
 EOF
     printf "\\n"
     printf "Do you accept the license terms? [yes|no]\\n"
-    printf "[no] >>> "
+    printf ">>> "
     read -r ans
     ans=$(echo "${ans}" | tr '[:lower:]' '[:upper:]')
-    while [ "$ans" != "YES" ] && [ "$ans" != "NO" ] && [ "$ans" != "" ]
+    while [ "$ans" != "YES" ] && [ "$ans" != "NO" ]
     do
         printf "Please answer 'yes' or 'no':'\\n"
         printf ">>> "

diff --git a/news/722-license-yn b/news/722-license-yn
@@ -0,0 +1,19 @@
+### Enhancements
+
+* <news item>
+
+### Bug fixes
+
+* Fix a regression in the license prompt on SH installers to require a explicit answer instead of defaulting to `no` on Enter. (#721 via #722)
+
+### Deprecations
+
+* <news item>
+
+### Docs
+
+* <news item>
+
+### Other
+
+* <news item>