Merge configuration files into pyproject.toml #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jaimergp
reviewed
Aug 1, 2024
jaimergp
reviewed
Aug 1, 2024
.flake8
Outdated
There was a problem hiding this comment.
Cannot we have this in pyproject.toml too?
There was a problem hiding this comment.
flake8 unfortunately doesn't support pyproject.toml
There was a problem hiding this comment.
Got it. We could move to ruff in a subsequent PR and get rid of this too.
jaimergp
reviewed
Aug 1, 2024
jaimergp
reviewed
Aug 1, 2024
jaimergp
reviewed
Aug 1, 2024
Co-authored-by: jaimergp <[email protected]>
Co-authored-by: jaimergp <[email protected]>
jaimergp
approved these changes
Aug 7, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert config files into
pyproject.tomlto use more modern python packaging practices.The lower bounds for
setuptoolsandsetuptools_scm[toml]were taken frommenuinst. I'm not sure if they need to be adjusted or can be removed altogether.Also add setuptools to host dependencies since it will be removed from pip's run dependencies on conda-forge eventually.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?