Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect original ssl_verify values #860

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Sep 13, 2024

Description

Closes #851

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 13, 2024
@jaimergp jaimergp marked this pull request as ready for review September 19, 2024 08:09
@jaimergp jaimergp requested a review from a team as a code owner September 19, 2024 08:09
@jaimergp
Copy link
Contributor Author

Fix confirmed at #851 (comment)

@marcoesters
Copy link
Contributor

While the fix makes sense to me, is there a way you could write a test to show it?

@jaimergp
Copy link
Contributor Author

Adding tests for this turned out to be a bit tricky (would need to patch CondaSession), so instead I went for simple and added a couple of assertions in the code. What do you think?

@jaimergp jaimergp merged commit 4d1abca into conda:main Oct 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

constructor does not respect ssl_verify set manually or in condarc
3 participants