Improve standalone executable type detection and handling #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
3 tasks
jaimergp
reviewed
Sep 28, 2024
| exe_name, exe_version = None, None | ||
| if sys.platform != "win32" and exe_name is not None and ( | ||
| exe_name == "micromamba" or Version(exe_version) < Version("23.11.0") | ||
| "Will assume it is compatible with shortcuts." |
There was a problem hiding this comment.
You are missing the exception here, so the %s placeholder above won't be filled in.
jaimergp
reviewed
Sep 28, 2024
jaimergp
previously approved these changes
Sep 28, 2024
Co-authored-by: jaimergp <[email protected]>
jaimergp
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements several improvements for how
constructordetects and handles which kind of standalone (conda-standalone,micromamba, etc.) executable is used:identify_conda_exeeverywhere instead of using the file name.mamba-type executables.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?