Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict Windows installation directory permission based on installation mode #873

Closed
wants to merge 2 commits into from
Closed

Restrict Windows installation directory permission based on installation mode #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad44202
Restrict permissions for all-users installations
marcoesters Oct 4, 2024
435e6bb
Add news file
marcoesters Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions constructor/nsis/main.nsi.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1372,11 +1372,11 @@ Section "Install"

# To address CVE-2022-26526.
# Revoke the write permission on directory "$INSTDIR" for Users if this is
# being run with administrative privileges. Users are:
# an all-users installation. Users are:
# AU - authenticated users
# BU - built-in (local) users
# DU - domain users
${If} ${UAC_IsAdmin}
${If} $InstMode == ${ALL_USERS}
${Print} "Setting installation directory permissions..."
AccessControl::DisableFileInheritance "$INSTDIR"
AccessControl::RevokeOnFile "$INSTDIR" "(AU)" "GenericWrite"
Expand Down
19 changes: 19 additions & 0 deletions news/873-justme-permission-bug
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* Restrict Windows directory permission based on installation mode, not privilege level. (#872 via #873)

### Deprecations

* <news item>

### Docs

* <news item>

### Other

* <news item>
Loading