fix: matchspec build / version from brackets and string serialization #917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were parsing brackets correctly, but we overrode it with
None
.This fixes matchspecs like
foo * [build="*bla*"]
For now this is no error when the build string is set twice (e.g.
foo * bar*[build="baz"]
). I am not sure if we should treat that as an error (at least in strict mode?). Same goes for the version.cc @jaimergp thanks for discovering this today!