Merge pull request #130 from ghkdwlgns612/fix-listener

Fix Issue: If status-listener throw exception, task not executed
conductor-oss · Aug 17, 2024 · 5425b3f · 5425b3f
2 parents 8914ae2 + b4a595f
commit 5425b3f
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/core/src/main/java/com/netflix/conductor/service/ExecutionService.java b/core/src/main/java/com/netflix/conductor/service/ExecutionService.java
@@ -189,7 +189,18 @@ public List<Task> poll(
                 .map(executionDAOFacade::getTaskModel)
                 .filter(Objects::nonNull)
                 .filter(task -> TaskModel.Status.IN_PROGRESS.equals(task.getStatus()))
-                .forEach(taskStatusListener::onTaskInProgress);
+                .forEach(
+                        task -> {
+                            try {
+                                taskStatusListener.onTaskInProgress(task);
+                            } catch (Exception e) {
+                                String errorMsg =
+                                        String.format(
+                                                "Error while notifying TaskStatusListener: %s for workflow: %s",
+                                                task.getTaskId(), task.getWorkflowInstanceId());
+                                LOGGER.error(errorMsg, e);
+                            }
+                        });
         executionDAOFacade.updateTaskLastPoll(taskType, domain, workerId);
         Monitors.recordTaskPoll(queueName);
         tasks.forEach(this::ackTaskReceived);