Fixed portRange using an unassigned var portRange.end instead of portRange.count #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto cus-417-pluralsight-gateway-helmchart-does-not-set-container-port
qboileau
reviewed
Sep 30, 2024
qboileau
approved these changes
Oct 1, 2024
BStarmerSmith
deleted the
cus-417-pluralsight-gateway-helmchart-does-not-set-container-port
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
add .Values.gateway.portRange.endcurrently to set the port range, although this works for actually setting the port range we should really change it to use the assigned and set count variable.Links into: #66