keep order from api response #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strokyl
force-pushed
the
keep_order_from_api_response
branch
2 times, most recently
from
93b1d83
to
30b419e
Compare
strokyl
force-pushed
the
keep_order_from_api_response
branch
from
30b419e
to
c4f8429
Compare
bthuillier
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with go is that when it deserializes from JSON it uses Map which loses order.
To avoid that I build a custom structure using orderedMap that keeps insertion order.
This structure supports JSON marshalling/unmarshalling and yaml marshalling.
But what's funny is that before, we already had a hack to have a fixed order for top-level field:
And unfortunately current release of console-plus does not respect this order.
So I had to keep old hack and adapt it to the new structure until we fix that on the backend