fix: adds docs and removes hardcoded secrets

confesi · Aug 13, 2023 · 2856ef9 · 2856ef9
1 parent 065b6ad
commit 2856ef9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 19 deletions.
diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml
@@ -8,25 +8,6 @@ on:
 
   workflow_dispatch:
 
-
-## Secrets I want to be in the env file for the unit tests
-
-
-# CIPHER_KEY="7571DFF385A22617"
-
-# CIPHER_NONCE="47363bcf91a1545668f0fd7a"
-
-# HKDF_SECRET="some-secret-string"
-
-# REDIS_CONN="redis:6379"
-
-# PUBLIC_DOC_ACCESS=true
-
-# MASK_SECRET="your_16_byte_key"
-
-
-
-
 jobs:
   build:
     runs-on: ubuntu-latest

diff --git a/README.md b/README.md
@@ -23,6 +23,10 @@
 
 Then put it here, like so `~/assets/IP2LOCATION/IP2LOCATION-LITE-DB5.IPV6.BIN`
 
+**Add required env variables to GitHub Secrets Manager for tests to pass:**
+
+Repo > Settings > Secrets and variables > Actions > New repository secret
+
 **Generate example `.env` file:**
 
 ```sh