Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Race Conditions #153

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Fix Race Conditions #153

wants to merge 13 commits into from

Conversation

TalentedB
Copy link
Contributor

@TalentedB TalentedB commented Aug 10, 2023

Features

Race Condition with
Votes: Fixed,
Comment Numerics: Fixed
Comment Counting: Fixed

Notes

Closes #152

@gitguardian
Copy link

gitguardian bot commented Aug 10, 2023

⚠️ GitGuardian has uncovered 119 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7645024 Bearer Token a7709e3 features/votes/requests.http View secret
7645024 Bearer Token 05a0d9f features/votes/requests.http View secret
7272655 Generic High Entropy Secret 5aedd1f features/notifications/requests.http View secret
7272655 Generic High Entropy Secret ccf0825 features/notifications/requests.http View secret
7272655 Generic High Entropy Secret a7709e3 features/notifications/requests.http View secret
7657397 Bearer Token fc030ce features/votes/requests.http View secret
7670828 Bearer Token 5aedd1f features/schools/requests.http View secret
7670828 Bearer Token 5aedd1f features/notifications/requests.http View secret
7670828 Bearer Token 5aedd1f features/reports/requests.http View secret
7670828 Bearer Token 5aedd1f features/posts/requests.http View secret
7670828 Bearer Token 5aedd1f features/admin/requests.http View secret
7670828 Bearer Token 5aedd1f features/comments/requests.http View secret
7670828 Bearer Token 5aedd1f features/feedback/requests.http View secret
7670828 Bearer Token 5aedd1f features/posts/requests.http View secret
7670828 Bearer Token 5aedd1f features/drafts/requests.http View secret
7670828 Bearer Token 5aedd1f features/posts/requests.http View secret
7670828 Bearer Token 5aedd1f features/admin/requests.http View secret
7670828 Bearer Token 5aedd1f features/schools/requests.http View secret
7670828 Bearer Token 5aedd1f features/user/requests.http View secret
7670828 Bearer Token 5aedd1f features/comments/requests.http View secret
7670828 Bearer Token 5aedd1f features/drafts/requests.http View secret
7670828 Bearer Token 5aedd1f features/votes/requests.http View secret
7670828 Bearer Token 5aedd1f features/auth/requests.http View secret
7670828 Bearer Token 5aedd1f features/comments/requests.http View secret
7670828 Bearer Token 5aedd1f features/notifications/requests.http View secret
7670828 Bearer Token 5aedd1f features/reports/requests.http View secret
7670828 Bearer Token 5aedd1f features/saves/requests.http View secret
7670828 Bearer Token 5aedd1f features/notifications/requests.http View secret
7670828 Bearer Token 5aedd1f features/hide_log/requests.http View secret
7670828 Bearer Token 5aedd1f features/admin/requests.http View secret
7657396 Bearer Token fc030ce features/posts/requests.http View secret
7657396 Bearer Token ccf0825 features/posts/requests.http View secret
7646583 Bearer Token ccf0825 features/admin/requests.http View secret
7646583 Bearer Token ccf0825 features/notifications/requests.http View secret
7646583 Bearer Token ccf0825 features/notifications/requests.http View secret
7646583 Bearer Token a7709e3 features/notifications/requests.http View secret
7646583 Bearer Token a7709e3 features/reports/requests.http View secret
7646583 Bearer Token a7709e3 features/posts/requests.http View secret
7646583 Bearer Token a7709e3 features/drafts/requests.http View secret
7646583 Bearer Token ccf0825 features/feedback/requests.http View secret
7646583 Bearer Token ccf0825 features/schools/requests.http View secret
7646583 Bearer Token ccf0825 features/drafts/requests.http View secret
7646583 Bearer Token a7709e3 features/admin/requests.http View secret
7646583 Bearer Token ccf0825 features/admin/requests.http View secret
7646583 Bearer Token a7709e3 features/auth/requests.http View secret
7646583 Bearer Token ccf0825 features/admin/requests.http View secret
7646583 Bearer Token ccf0825 features/notifications/requests.http View secret
7646583 Bearer Token ccf0825 features/user/requests.http View secret
7646583 Bearer Token a7709e3 features/comments/requests.http View secret
7646583 Bearer Token a7709e3 features/feedback/requests.http View secret
7646583 Bearer Token ccf0825 features/auth/requests.http View secret
7646583 Bearer Token a7709e3 features/saves/requests.http View secret
7646583 Bearer Token ccf0825 features/saves/requests.http View secret
7646583 Bearer Token ccf0825 features/hide_log/requests.http View secret
7646583 Bearer Token a7709e3 features/hide_log/requests.http View secret
7646583 Bearer Token ccf0825 features/reports/requests.http View secret
7646583 Bearer Token a7709e3 features/admin/requests.http View secret
7646583 Bearer Token a7709e3 features/admin/requests.http View secret
7646583 Bearer Token a7709e3 features/notifications/requests.http View secret
7646583 Bearer Token a7709e3 features/user/requests.http View secret
7646583 Bearer Token a7709e3 features/schools/requests.http View secret
7646583 Bearer Token a7709e3 features/notifications/requests.http View secret
7646583 Bearer Token ccf0825 features/comments/requests.http View secret
7645023 Bearer Token 05a0d9f features/comments/requests.http View secret
7355027 Generic High Entropy Secret ccf0825 features/notifications/requests.http View secret
7355027 Generic High Entropy Secret 5aedd1f features/notifications/requests.http View secret
7355027 Generic High Entropy Secret a7709e3 features/notifications/requests.http View secret
6793264 Generic High Entropy Secret ccf0825 features/auth/requests.http View secret
6793264 Generic High Entropy Secret 5aedd1f features/user/requests.http View secret
6793264 Generic High Entropy Secret a7709e3 features/posts/requests.http View secret
6793264 Generic High Entropy Secret ccf0825 features/user/requests.http View secret
6793264 Generic High Entropy Secret 5aedd1f features/auth/requests.http View secret
6793264 Generic High Entropy Secret ccf0825 features/posts/requests.http View secret
6793264 Generic High Entropy Secret a7709e3 features/auth/requests.http View secret
6793264 Generic High Entropy Secret a7709e3 features/user/requests.http View secret
6793264 Generic High Entropy Secret 5aedd1f env-example View secret
6793264 Generic High Entropy Secret 63af96c features/auth/requests.http View secret
6793264 Generic High Entropy Secret 63af96c features/user/requests.http View secret
6793264 Generic High Entropy Secret 204b1c5 features/user/requests.http View secret
6793264 Generic High Entropy Secret 204b1c5 features/auth/requests.http View secret

and 39 others.

🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Race Condition With Voting
2 participants