Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds indexes to many columns #165

Merged
merged 2 commits into from
Aug 28, 2023
Merged

feat: Adds indexes to many columns #165

merged 2 commits into from
Aug 28, 2023

Conversation

TalentedB
Copy link
Contributor

Features

Adds many index to many columns

Notes

Closes #100

@gitguardian
Copy link

gitguardian bot commented Aug 26, 2023

⚠️ GitGuardian has uncovered 38 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
6793264 Generic High Entropy Secret 85c8d8e features/auth/requests.http View secret
6793264 Generic High Entropy Secret 85c8d8e features/user/requests.http View secret
6793264 Generic High Entropy Secret 92767e7 features/user/requests.http View secret
6793264 Generic High Entropy Secret 92767e7 features/auth/requests.http View secret
7272655 Generic High Entropy Secret 85c8d8e features/notifications/requests.http View secret
7272655 Generic High Entropy Secret 92767e7 features/notifications/requests.http View secret
7355027 Generic High Entropy Secret 85c8d8e features/notifications/requests.http View secret
7355027 Generic High Entropy Secret 92767e7 features/notifications/requests.http View secret
7906647 Bearer Token 85c8d8e features/hide_log/requests.http View secret
7906647 Bearer Token 85c8d8e features/feedback/requests.http View secret
7906647 Bearer Token 85c8d8e features/comments/requests.http View secret
7906647 Bearer Token 85c8d8e features/admin/requests.http View secret
7906647 Bearer Token 85c8d8e features/notifications/requests.http View secret
7906647 Bearer Token 85c8d8e features/saves/requests.http View secret
7906647 Bearer Token 85c8d8e features/user/requests.http View secret
7906647 Bearer Token 85c8d8e features/posts/requests.http View secret
7906647 Bearer Token 85c8d8e features/notifications/requests.http View secret
7906647 Bearer Token 85c8d8e features/schools/requests.http View secret
7906647 Bearer Token 85c8d8e features/reports/requests.http View secret
7906647 Bearer Token 85c8d8e features/drafts/requests.http View secret
7906647 Bearer Token 85c8d8e features/votes/requests.http View secret
7906647 Bearer Token 85c8d8e features/notifications/requests.http View secret
7906647 Bearer Token 85c8d8e features/auth/requests.http View secret
7907134 Bearer Token 92767e7 features/saves/requests.http View secret
7907134 Bearer Token 92767e7 features/reports/requests.http View secret
7907134 Bearer Token 92767e7 features/admin/requests.http View secret
7907134 Bearer Token 92767e7 features/notifications/requests.http View secret
7907134 Bearer Token 92767e7 features/schools/requests.http View secret
7907134 Bearer Token 92767e7 features/auth/requests.http View secret
7907134 Bearer Token 92767e7 features/user/requests.http View secret
7907134 Bearer Token 92767e7 features/votes/requests.http View secret
7907134 Bearer Token 92767e7 features/hide_log/requests.http View secret
7907134 Bearer Token 92767e7 features/notifications/requests.http View secret
7907134 Bearer Token 92767e7 features/drafts/requests.http View secret
7907134 Bearer Token 92767e7 features/notifications/requests.http View secret
7907134 Bearer Token 92767e7 features/posts/requests.http View secret
7907134 Bearer Token 92767e7 features/comments/requests.http View secret
7907134 Bearer Token 92767e7 features/feedback/requests.http View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Member

@mattrltrent mattrltrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just merged and fixed some conflicts.

@mattrltrent mattrltrent merged commit e9eb786 into main Aug 28, 2023
1 of 2 checks passed
@mattrltrent mattrltrent deleted the indexing_columns branch August 28, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update/add Postgres indices to make all queries efficient. Else, stuff could get REALLY slow.
2 participants