libvirt: Support Ubuntu 23.04+ #2005
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've manually tested this on 22.04 and 24.04 and it all (non-kbs) test passed for me |
|
It looks like in the CI the shell reload to pick up the new path isn't working, which might be to do with GHA isolating PATH between steps, so we might need some PATH update in the workflow, so putting this in draft for now. |
I hope my workflow commit will do the trick. I'm not sure we can test it though, so maybe the best plan is to split out the workflow change and deliver it separately? |
In newer versions of Ubuntu running `pip3 install kcli` results in
the following error:
```
error: externally-managed-environment
× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
python3-xyz, where xyz is the package you are trying to
install.
...
```
Solutions seem to be either use a virtual environment,
install the package with apt (which isn't available for us as we need),
or use pipx if installing an application, which we are.
This attempts to use the logic to install with pipx, including a
shell reload at the end of the script to force the PATH to be updated
Signed-off-by: stevenhorsman <[email protected]>
With pipx to install kcli, we now need `${HOME}/.local/bin`
to be added to `PATH`, so that we can pick up the install,
so try exporting this to $GITHUB_PATH
Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
force-pushed
the
ubuntu-24.04-kcli-install
branch
from
a7ff93e
to
4de1548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newer versions of Ubuntu running
pip3 install kcliresults in the following error:Solutions seem to be either use a virtual environment, install the package with apt (which isn't available for us as we need), or use pipx if installing an application, which we are.
This attempts to use the logic to install with pipx, including a shell reload at the end of the script to force the PATH to be updated