Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Podvm guest components caching #2033

Conversation

stevenhorsman
Copy link
Member

podvm: Pull the guest-components from cache
To reduce time in the podvm build, rather than compiling the guest-components
binaries each time, we can just re-use the cached version that the
kata-containers CI build publishes.

Note: This adds a restriction that means we can only use versions of
guest-components that have been included in a kata-containers build.
I think this is okay as we want to stay in sync with them anyway

Fixes: #1816

@stevenhorsman stevenhorsman added the test_e2e_libvirt Run Libvirt e2e tests label Sep 9, 2024
@stevenhorsman stevenhorsman changed the title Podvm guest components caching WIP: Podvm guest components caching Sep 9, 2024
To reduce time in the podvm build, rather than compiling the guest-components
binaries each time, we can just re-use the cached version that the
kata-containers CI build publishes.

**Note:** This adds a restriction that means we can only use versions of
guest-components that have been included in a kata-containers build.
I think this is okay as we want to stay in sync with them anyway

Fixes: confidential-containers#1816

Signed-off-by: stevenhorsman <[email protected]>
- Now we aren't building the kata-agent and guest-components, we don't need
rust installed in the podvm builder
- TODO update Azure podvm workflow and then remove from the versions.yaml too?
@mkulke
Copy link
Contributor

mkulke commented Sep 27, 2024

I think the kata guest components are too specific to be used in peerpods. but maybe we can use parts of it, attestation-agent will have hardware dependencies, e.g you need tdx guest attester libraries that are only available ox 86_64 naturally, otoh the peerpods TEEs (tpm, se) require openssl and are not compatible with musl.

but we can maybe build and push specific binaries in the guest-components repo (think: .../guest-components:$sha-glibc-x86_64 and .../guest-components-$sha-glibc-s390x)

@stevenhorsman
Copy link
Member Author

I think the kata guest components are too specific to be used in peerpods. but maybe we can use parts of it, attestation-agent will have hardware dependencies, e.g you need tdx guest attester libraries that are only available ox 86_64 naturally, otoh the peerpods TEEs (tpm, se) require openssl and are not compatible with musl.

but we can maybe build and push specific binaries in the guest-components repo (think: .../guest-components:$sha-glibc-x86_64 and .../guest-components-$sha-glibc-s390x)

Yeah, I was coming to the same conclusion with this PR, hence leaving it in draft. It would be nice to remove all the rust related code from this repo, but agree that we need the different flavours built and cached and guest-components make sense as the place to do that and then the kata rootfs code can consume the variants it needs there too.

I'll close this PR for clarity - we can also re-open it later if needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test_e2e_libvirt Run Libvirt e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podvm: component caching
2 participants