Clean out-of-date code and documents of AA. #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, https://github.com/confidential-containers/guest-components/blob/main/Makefile should be also be considered as it defines |
Signed-off-by: Jiale Zhang <[email protected]>
jialez0
force-pushed
the
clean-aa
branch
4 times, most recently
from
940ac2a to
ef7eeb2
Compare
Signed-off-by: Jiale Zhang <[email protected]>
Signed-off-by: Jiale Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to development history, AA has long relied on assuming the responsibility of Unwrap Key and Get Resource, which is actually not in line with AA's positioning. Now we have a CDH that is more suitable for these features, and it already supports the functions that were originally supported by AA. Therefore, this PR will clean up the redundant code and documents in AA, making AA's positioning clearer: A user space service focused on Attestation itself.
Note: This PR has removed KBC related code and documentation because we no longer need the KBC module, and the KBC related functions have been implemented by CDH using a more elegant architecture.
cc @Xynnn007
I will fix the CI error after rebasing #427