Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve KBS protocol version handling and bump the version to v0.1.1 due to kbs-types changes #628

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Improve KBS protocol version handling and bump the version to v0.1.1 due to kbs-types changes #628

merged 4 commits into from
Aug 6, 2024

Commits on Aug 6, 2024

  1. kbs_protocol: fix typo with UnAuthorized error 

    Signed-off-by: Mikko Ylinen <[email protected]>
    @mythi
    mythi committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    3028a1b View commit details
    Browse the repository at this point in the history

  2. kbs_protocol: handle ProtocolVersion error 

    The RCAR client code currently ignores any errors for "request". Such errors
can still happen, e.g., when 'version' field is rejected by KBS.

Without catching errors we try to decode the Challenge json body but it actually
contains the error information in it which results in decode errors instead.

KBS added a new ProtocolVersion error which is now catched by the RCAR
client code. The error is reported to the user if the client and server
use incompatible versions.

Signed-off-by: Mikko Ylinen <[email protected]>
    @mythi
    mythi committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    f422030 View commit details
    Browse the repository at this point in the history

  3. kbs_protocol: skip RCAR client tests when ProtocolVersion error occurs 

    The current setup with trustee repo for KBS server and guest-components
repo for kbs_protocol client code has a cyclic dependency problem.

test_client test uses "KBS latest" container image which won't work if
any RCAR client code changes that change the protocol semantics are made.

The suggested approach to break the cyclic dependency is to get the RCAR
client changes merged first with a KBS protocol version bump. The
RCAR client test is modified to skip the checks in case the "KBS
latest" server returns ProtocolVersion error.

Following this, the corresponding KBS server changes are made in trustee
repo with an update to both kbs_protocol for kbs-client builds and the
server supported protocol version.

Signed-off-by: Mikko Ylinen <[email protected]>
    @mythi
    mythi committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b28be70 View commit details
    Browse the repository at this point in the history

  4. chore(deps): Bump kbs-types from 0.6.0 to 0.7.0 

    kbs-types introduces a break in JSON semantics so we bump the
kbs protocol version from 0.1.0 to 0.1.1.

Signed-off-by: Mikko Ylinen <[email protected]>
    @mythi
    mythi committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e573dd1 View commit details
    Browse the repository at this point in the history