tests/e2e: Jenkins to GHA migration for SEV and SNP #352
Conversation
AdithyaKrishnan
force-pushed
the
main
branch
2 times, most recently
from
cf1c011
to
4828f0f
Compare
AdithyaKrishnan
changed the title
|
@portersrc @fitzthum DCO passing finally. |
| timeout-minutes: 45 | ||
| run: | | ||
| cd tests/e2e | ||
| export PATH="$PATH:/usr/local/bin" |
There was a problem hiding this comment.
I think you can specify this as part of the env below
| - name: Run e2e tests | ||
| timeout-minutes: 45 | ||
| run: | | ||
| cd tests/e2e |
There was a problem hiding this comment.
You can use the working-directory field to specify where this step runs rather than doing a cd
| steps: | ||
| - name: Take a pre-action for self-hosted runner | ||
| run: | | ||
| if [ -f ${HOME}/script/pre_action.sh ]; then |
There was a problem hiding this comment.
This is your own script that lives on the CI machine? What will happen if it isn't there?
There was a problem hiding this comment.
The pre-action script is not mine and I believe it's Choi's per my understanding. It would be used by both ccruntime_e2e_amd.yaml as well as the ccruntime_e2e.yaml.
| - name: Install deps | ||
| run: | | ||
| sudo apt-get update -y | ||
| sudo apt-get install -y ansible python-is-python3 |
There was a problem hiding this comment.
Is it necessary to install these packages every time? I don't see them being uninstalled.
| workflow_call: | ||
|
|
||
| permissions: | ||
| contents: read |
AdithyaKrishnan
changed the title
|
Ok, higher level question here. Maybe @wainersm will have some good advice. Do you think we should have a separate workflow for SEV? I'm not sure if this is going to scale very well as we introduce more tests. Can we instead modify the existing e2e workflow to add SEV/SNP support? |
Well the workflow should be similar, shouldn't it? Only the set of tests and perhaps some setup parts will differ and that should be part of the scripts but IMO the workflows should be shared as much as possible. |
Yes, that's how I see it as well. |
|
See https://github.com/confidential-containers/operator/pull/383/files for an example |
The ccruntime-pr.yaml file has been modified and works only for amd specific tests currently. Work adds on to operator pull 295